Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Web UI so it's accessible on both ipv4 and ipv6 #1136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

therocco
Copy link
Contributor

Description

Tweak default config file so it bootstraps the Web UI server to both ipv6 and ipv4 by default. I also left a comment in there explaining how to revert to only loading the server on an ipv4 address by replacing the address with 0.0.0.0. I also updated the server.py file so it formats the ipv6 url in a more user friendly manner

Motivation and Context

  • I have raised an issue to propose this change (required)

I didn't raise the issue but an enhancement request was put in so this addresses and closes #915

FIXES #915

How Has This Been Tested?

I tested it for several hours locally tethering my pwnagotchi to my laptop and desktop via usb, bluetooth, and a USB Wi-Fi dongle that I had laying around. Everything worked as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

For the documentation I left comments in the default config.toml file that explains the fix. It's really pretty basic. Instead of loading the web UI on 0.0.0.0 we instead load it on the ipv6 equivalent :: and in turn ipv6 routes traffic back to ipv4

@Yggdrasil-Engineering
Copy link

For what it's worth-Tested the fix and it works great! ipv6 connection to Web UI works fast and as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let web UI listen to IPv6
2 participants